eliminate unused other_cost parameter.

cost of other races is defined by their recruitcost.

res/e3a/races.xml

@@ -36,7 +36,6 @@
     <ai splitsize="10000" moverandom="yes" learn="yes"/>
     <function name="itemdrop" value="defaultdrops"/>
     <param name="other_race" value="elf"/>
-    <param name="other_cost" value="500"/>
     <skill name="riding" modifier="+1"/>
     <skill name="shipcraft" modifier="2"/>
     <skill name="sailing" modifier="2"/>
@@ -51,7 +50,6 @@
     <ai splitsize="10000" moverandom="yes" learn="yes"/>
     <function name="itemdrop" value="defaultdrops"/>
     <param name="other_race" value="troll"/>
-    <param name="other_cost" value="500"/>
 
     <skill name="bow" speed="+5"/>
     <skill name="building" modifier="1"/>
@@ -80,7 +78,6 @@
     <ai splitsize="10000" moverandom="yes" learn="yes"/>
     <function name="itemdrop" value="defaultdrops"/>
     <param name="other_race" value="dwarf"/>
-    <param name="other_cost" value="500"/>
     <param name="luxury_trade" value="600"/>
     <skill name="bow" modifier="-1"/>
     <skill name="building" modifier="1"/>

res/races/goblin-2.xml

@@ -8,7 +8,6 @@ getitem="yes" equipment="yes" healing="2.0">
   <function name="itemdrop" value="defaultdrops"/>
   <param name="hunger.damage" value="1d8+7"/>
   <param name="other_race" value="demon"/>
-  <param name="other_cost" value="500"/>
   <param name="recruit_multi" value="0.5"/>
   <skill name="building" modifier="1"/>
   <skill name="cartmaking" modifier="-1"/>

res/races/goblin-3.xml

@@ -8,7 +8,6 @@ getitem="yes" equipment="yes" healing="2.0">
   <function name="itemdrop" value="defaultdrops"/>
   <param name="hunger.damage" value="1d8+7"/>
   <param name="other_race" value="demon"/>
-  <param name="other_cost" value="500"/>
   <param name="recruit_multi" value="0.5"/>
   <skill name="cartmaking" modifier="-1"/>
   <skill name="catapult" modifier="1"/>

src/economy.c

@@ -427,7 +427,6 @@ static int recruit_cost(const faction * f, const race * rc)
     }
     else if (valid_race(f, rc)) {
         return rc->recruitcost;
-        /*      return get_param_int(f->race->parameters, "other_cost", -1); */
     }
     return -1;
 }