Marc
/
server
forked from github/server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

log a warning when passwords would fail for being case-sensitive. 

add a test to enforce the status quo, for now.
This commit is contained in:
Enno Rehling 2016-01-12 00:52:42 +01:00
parent b0b63747c4
commit 19390dd8e2
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/kernel/faction.c
View File

@ -313,7 +313,13 @@ unit *addplayer(region * r, faction * f)
bool checkpasswd(const faction * f, const char *passwd)
{
return (passwd && unicode_utf8_strcasecmp(f->passw, passwd) == 0);
if (!passwd) return false;
if (strcmp(f->passw, passwd)==0) return true;
if (unicode_utf8_strcasecmp(f->passw, passwd) == 0) {
log_warning("case-sensitive password check failed: %s", factionname(f));
return true;
}
return false;
}
variant read_faction_reference(struct storage * store)

11
src/kernel/faction.test.c
View File

@ -119,6 +119,16 @@ static void test_addfaction(CuTest *tc) {
test_cleanup();
}
static void test_check_passwd(CuTest *tc) {
faction *f;
f = test_create_faction(0);
faction_setpassword(f, "password");
CuAssertIntEquals(tc, true, checkpasswd(f, "password"));
CuAssertIntEquals(tc, true, checkpasswd(f, "PASSWORD"));
CuAssertIntEquals(tc, false, checkpasswd(f, "assword"));
}
static void test_get_monsters(CuTest *tc) {
faction *f;
@ -185,5 +195,6 @@ CuSuite *get_faction_suite(void)
SUITE_ADD_TEST(suite, test_get_monsters);
SUITE_ADD_TEST(suite, test_set_origin);
SUITE_ADD_TEST(suite, test_set_origin_bug);
SUITE_ADD_TEST(suite, test_check_passwd);
return suite;
}