cppcheck style fixes

src/kernel/faction.c

@@ -195,7 +195,7 @@ const char *factionname(const faction * f)
     char *ibuf = idbuf[(++nextbuf) % 8];
 
     if (f && f->name) {
-        slprintf(ibuf, sizeof(name), "%s (%s)", f->name, itoa36(f->no));
+        slprintf(ibuf, sizeof(idbuf[0]), "%s (%s)", f->name, itoa36(f->no));
     }
     else {
         strcpy(ibuf, "Unbekannte Partei (?)");

src/move.c

@@ -1751,6 +1751,7 @@ static void sail(unit * u, order * ord, region_list ** routep, bool drifting)
      * befahrene Region. */
 
     while (next_point && current_point != next_point && step < k) {
+        int reason;
         const terrain_type *tthis = current_point->terrain;
         /* these values need to be updated if next_point changes (due to storms): */
         const terrain_type *tnext = next_point->terrain;

src/spells.c

@@ -5541,8 +5541,6 @@ int sp_showastral(castorder * co)
 
     free_regionlist(rl);
     return cast_level;
-    UNUSED_ARG(co);
-    return 0;
 }
 #endif