Marc
/
server
forked from github/server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

coverity scan CIDs 22540 22541 22546: resource leak 

the calendar should only ever be initialized once, but based on static analysis, I agree that this was sloppy.
This commit is contained in:
Enno Rehling 2015-10-29 09:56:53 +01:00
parent 2372d3aacd
commit 8675002e68
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/kernel/xmlreader.c
View File

@ -389,7 +389,8 @@ static int parse_calendar(xmlDocPtr doc)
int i;
weeks_per_month = nsetWeeks->nodeNr;
assert(!weeknames);
free(weeknames);
free(weeknames2);
weeknames = malloc(sizeof(char *) * weeks_per_month);
weeknames2 = malloc(sizeof(char *) * weeks_per_month);
for (i = 0; i != nsetWeeks->nodeNr; ++i) {
@ -431,9 +432,11 @@ static int parse_calendar(xmlDocPtr doc)
int i;
months_per_year = nsetMonths->nodeNr;
assert(!monthnames);
free(monthnames);
monthnames = malloc(sizeof(char *) * months_per_year);
free(month_season);
month_season = malloc(sizeof(int) * months_per_year);
free(storms);
storms = malloc(sizeof(int) * months_per_year);
for (i = 0; i != nsetMonths->nodeNr; ++i) {